Skip to content

fix(api): normalize telemetry query bounds for ClickHouse DateTime #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobwl wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(api): normalize telemetry query bounds for ClickHouse DateTime #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/api/src/routes/v2/telemetry.http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ describe("v2 telemetry reads over HTTP", () => {
await harness.dispose()
})

it("preserves fractional bounds and reads complete traces by their sorting-key identity", async () => {
it("normalizes warehouse bounds to second precision and reads complete traces by sorting-key identity", async () => {
const observedSql: string[] = []
const observingWarehouse: WarehouseQueryServiceShape = {
...warehouseStub,
Expand All @@ -481,8 +481,8 @@ describe("v2 telemetry reads over HTTP", () => {
})
expect(logs.status).toBe(200)
const logSql = observedSql.find((sql) => sql.includes("FROM logs"))
expect(logSql).toContain("'2026-07-15 12:00:00.900'")
expect(logSql).toContain("'2026-07-15 12:00:01.100'")
expect(logSql).toContain("'2026-07-15 12:00:00'")
expect(logSql).toContain("'2026-07-15 12:00:01'")

observedSql.length = 0
const trace = await harness.request("GET", `/v2/traces/${TRACE_ID}`, key.secret)
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/routes/v2/telemetry.http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const toWarehouseDateTime = (value: string, param: string) => {
const ms = Date.parse(value)
return Number.isNaN(ms)
? Effect.fail(invalidRequest("parameter_invalid", `Invalid ISO-8601 timestamp for ${param}.`, param))
: Effect.succeed(formatWarehouseDateTimeMs(ms))
: Effect.succeed(formatWarehouseDateTime(ms))
}

const parseWindow = (
Expand Down