Skip to content

Fix the GitHub install admin tests that broke main - #1698

Merged
Makisuo merged 1 commit into
mainfrom
fix/github-connect-admin-tests-initiator
Oct 22, 2026
Merged

Fix the GitHub install admin tests that broke main#1698
Makisuo merged 1 commit into
mainfrom
fix/github-connect-admin-tests-initiator

test(integrations): pass the initiator in the GitHub install admin tests

0c880a6
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 22, 2026 in 12s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
One-argument test fix in a case loop; the state minted at line 279 carries the same org and user the case now passes.
no findings · tests covered · risk low

Passes the OAuthFlowInitiator that completeConnect requires in the six adminCases of GithubConnectService.test.ts, so the call reaches the role lookup instead of failing on state consumption. Safe to merge.

  • adminCases in GithubConnectService.test.ts pass INITIATOR to completeConnect
What was checked
  • startConnect at test line 279 mints the state for org_test/user_1, the same pair in INITIATOR (line 55), so states.consume accepts it
  • The cases still assert the role URL was hit, and bound/queue outcomes, so a refusal before the role lookup still fails the test

0c880a6 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot