Repository navigation
fix: make app boot recover instead of hanging on the loader - #337
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 15, 2026 in 6m 13s
Confidence 9/10 · No issues found
🟢 Confidence 9/10 · safe to merge
Session- and org-gate changes touch auth-adjacent state, but each risky path has a story test I traced through the update and view code.
quality 100/100 · no findings · tests covered · risk medium
The boot path now surfaces failures instead of hanging: live queries report a stall, the org gate has explicit Found/NotFound/Stalled states, stalled loaders offer a reload, and an unreachable API no longer signs the user out. Contained, and pinned by tests that exercise each of those paths.
readSessionfails when the API cannot answer instead of silently returningSignedOutliveQueryStreamtakesonStalled, andappLoadershows a note plus aReloadbuttonorgLoad(Found/NotFound/Stalled) replacesloadedOrgSlug, and an unknown workspace shows a not-found pageelectricOnErrorretries a 401 with a fresh token and stops the shape on other errors
What was checked
readBrowserSessionstill returnsSignedOutfor a missing session (auth.ts:24-28), so droppingorElseSucceedcannot strand a signed-out browser on the loaderStalledOrganizationignores a stall once the slug is Found/NotFound (main.ts:502-509), matching the root story testisCurrentUserStalledis read by the view (view.ts:164), so the stalleduser.meloader does offer reload
8785304 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading