Skip to content

[WIP] Rails-8 #9753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrafanie wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −11
Open

[WIP] Rails-8 #9753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d0a6e
Allow rails 8.0, enforce 7.2.3 minimum
jrafanie Dec 5, 2025
98cf04e
Upgrade actioncable package for rails 8
jrafanie Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/notifications/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import ActionCable from 'actioncable';
import * as ActionCable from '@rails/actioncable';

import { API } from '../http_api';
import { addNotification, initNotifications } from '../miq-redux/actions/notifications-actions';
Expand Down
2 changes: 1 addition & 1 deletion manageiq-ui-classic.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |s|
s.executables = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
s.require_paths = ["lib"]

s.add_dependency "rails", ">= 7.0.8", "<8.0"
s.add_dependency "rails", ">= 7.2.3", "<8.1"

s.add_dependency "execjs", "2.8.1" # Note: 2.8.1 requires uglifier 4.2.0 to defer uglifier asset compilation until asset compilation time: https://github.com/rails/execjs/issues/105
s.add_dependency "high_voltage", "~> 3.0.0"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"@manageiq/ui-components": "~1.6.1",
"@novnc/novnc": "~1.2.0",
"@pf3/select": "~1.12.6",
"@rails/actioncable": "^8.0.0",
"@tshepomgaga/aws-sfn-graph": "0.0.6",
"actioncable": "^5.2.4-2",
"angular": "~1.8.3",
"angular-animate": "~1.8.3",
"angular-bootstrap-switch": "~0.5.2",
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,6 +2383,13 @@ __metadata:
languageName: node
linkType: hard

"@rails/actioncable@npm:^8.0.0":
version: 8.1.100
resolution: "@rails/actioncable@npm:8.1.100"
checksum: 10/eed05106c571065d32238d7b6832a2b4e7db79c8e0d1b3dcefd484a7f89914914db13c1d1b5cae763b266e6697f358523e5ce52871d27b5fafb1dd28d63992eb
languageName: node
linkType: hard

"@sinonjs/commons@npm:^1.7.0":
version: 1.8.6
resolution: "@sinonjs/commons@npm:1.8.6"
Expand Down Expand Up @@ -3590,13 +3597,6 @@ __metadata:
languageName: node
linkType: hard

"actioncable@npm:^5.2.4-2":
version: 5.2.8
resolution: "actioncable@npm:5.2.8"
checksum: 10/5cdc4d60689d0244d532d37a64e0c0b186f958cc94674f1b416308afcde2bd65c84b9c34e82723004fc5c235cb5759acd6ed12456153551a6ce7cd8afff653f4
languageName: node
linkType: hard

"adjust-sourcemap-loader@npm:3.0.0":
version: 3.0.0
resolution: "adjust-sourcemap-loader@npm:3.0.0"
Expand Down Expand Up @@ -12889,8 +12889,8 @@ __metadata:
"@manageiq/ui-components": "npm:~1.6.1"
"@novnc/novnc": "npm:~1.2.0"
"@pf3/select": "npm:~1.12.6"
"@rails/actioncable": "npm:^8.0.0"
"@tshepomgaga/aws-sfn-graph": "npm:0.0.6"
actioncable: "npm:^5.2.4-2"
angular: "npm:~1.8.3"
angular-animate: "npm:~1.8.3"
angular-bootstrap-switch: "npm:~0.5.2"
Expand Down
Loading