Removed va_list parameter from Udp_free_logging #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now udp_logging:init accepts hostname in addition to IP addresses. Depreceated Methods replaced: - use ofpcTaskGetName instead of pcTaskGetTaskName - use of getaddrinfo instead of inet_aton Fixed C++ compiler warnings
Contributor
Author
|
This change is incompatible for C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter va_list is not required in udp_free_logging , but makes code more unreadable.
It has been removed.
Additionally: udp_logging_init calls now udp_free_logging if udp logging was configured previously.
Now, another udp_logging_init with different parameter can change the logging destination.
Improved logging messages in case of shutdown