Conversation
close() awaited cancel_waiter with no timeout, and connection_lost only resolved waiter. A frozen server left close() hanging even after the socket dropped. Fixes MagicStack#1356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1356.
close(timeout=)waits forcancel_waiterbefore it appliestimeout. That future is only completed when ReadyForQuery arrives on the original socket._on_connection_lostresolveswaiterand leaves the cancel futures pending, so a frozen server (or a pooler that then drops the client) can leaveclose()hung forever.SQLAlchemy's asyncpg dialect hits this when it invalidates a connection after
TimeoutErrorwithclose(timeout=2).The cancel wait now uses the same timeout, a lost transport completes the cancel futures, and
abort()still drops the socket ifclose()already setclosing.