Skip to content

Conversation

@S-Numan
Copy link

@S-Numan S-Numan commented Jun 11, 2025

Not thoroughly tested.

Handle position of bounty shown to user properly. E.G, no arrow and name showing the destination when only the constellation should be showing, like vanilla!

Plot course now follows the above as well.
When job_show_distance is "None" or "Distance", plot course is removed entirely. As there is no course.
When job_show_distance is vanilla, plot course only plots towards the center of the constellation, not the specific sector.

Implements job_show_distance = "distance"

Removed AssassinationMagicBountyInfo and added into MagicBountyInfo, to remove duplicated code. (why does that class exist anyway?)

Took into account the `job_show_distance` "distance" setting.

Removed AssassinationMagicBountyInfo and added into MagicBountyInfo. (why does that class exist anyway?)

Handle position of bounty shown to user properly. E.G, no arrow and name showing the destination when only the constellation should be showing, like vanilla!

Plot course now follows the above as well. When job_show_distance is "None" or "Distance", plot course is removed entirely.
@S-Numan S-Numan marked this pull request as draft June 11, 2025 13:35
@wispborne
Copy link
Member

For the route stuff, I would like to keep that. When checking bounties, being able to see how far away they are is very convenient, even if it isn't the exact location. Without showing the arrow, you have to zoom out of each bounty's minimap in order to see where it is relative to you.

I'll think about the other changes.

@S-Numan
Copy link
Author

S-Numan commented Jun 14, 2025

Might of miscommunicated what has changed a bit.
When in doubt, show an image.
image
image

It looks like this.
Arrow is still shown, but it points the player towards the center of the constellation instead of at the destination.
Plot course also takes the player towards the center of the constellation.

The bounty map is automatically zoomed out so that the bounty and player is included.

Functionality is meant to replicate the example file examples, ideally.


        "job_show_distance": "vague", # Default: "vanillaDistance".
                # How precisely the distance to the target is shown on the bounty board.
                # none: Do not show the distance.
                # vague: "The target is located somewhere in the vicinity of the core worlds."
                # distance: "It is located roughly %s LY away from your current position."
                # system: "The target is located in the <system> system."
				# vanilla: "The target is located near a giant in a system with a yellow primary star, in the Nebulon constellation." Also shows a map during the bar dialog
                # vanillaDistance: "The target is located near a giant in a system with a yellow primary star, in the Nebulon constellation. It is located roughly %s LY away from your current position." Also shows a map during the bar dialog
				# exact: "The target is located near X in the Y system." Also shows a map during the bar dialog

Thus when none, no destination is shown.
When distance, only the distance from the bounty is shown as described in the example.
When vanilla, behavior is changed to follow vanilla behavior, rather than the previous behavior of showing an arrow directly to the destination, defeating the purpose of only telling the player the constellation and star type the bounty is in.

Vague is left unimplemented as some mods (for example: Seeker) use it incorrectly. And it doesn't seem like a good mechanic anyway so to avoid possible issues, I've commented it out.

Let me know if I've misinterpreted something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants