Small persistence improvements

[sven-n]

• Implemented IAssignable for the PlugInConfiguration to allow live configuration changes while the server is running
• Made sure that the ef core context model of TypedContext is properly initialized before accessing some public properties.

[gemini-code-assist]

Summary of Changes

Hello @sven-n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces key improvements to the application's persistence layer, enhancing both flexibility and stability. It enables dynamic updates for plugin configurations, allowing for changes to be applied without service interruption. Additionally, it fortifies the Entity Framework Core context initialization process, ensuring that model-related properties are always accessed safely and reliably, thereby preventing potential errors in data access operations.

Highlights

• Live Configuration Changes: The PlugInConfiguration class now implements IAssignable and ICloneable interfaces, enabling live configuration changes while the server is running. This allows for dynamic updates to plugin configurations without requiring a server restart.
• Robust EF Core Context Initialization: The TypedContext class has been improved to ensure its Entity Framework Core context model is properly initialized before accessing critical properties like EditTypes or BackReferenceTypes. This prevents potential runtime errors that could occur if the model was not fully prepared.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces improvements to persistence logic. In PlugInConfiguration, IAssignable is implemented to allow live configuration changes. However, there are a couple of issues in the implementation: the AssignValuesOf(object ...) method has a too-specific type check, and the Id property is incorrectly being assigned, which could lead to primary key violations. In TypedContext, a change was made to ensure the EF Core model is initialized before use, which is a good improvement. However, this exposes a critical underlying issue where TypedContext customizes the model based on an instance property without implementing IModelCacheKeyFactory, which will cause model caching problems in Entity Framework Core. I've provided detailed comments on these points.

[sven-n]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces two valuable improvements. First, it implements IAssignable for PlugInConfiguration, enabling live configuration changes, which enhances flexibility. Second, it improves the robustness of TypedContext by ensuring the EF Core context model is initialized before access, preventing potential race conditions and errors. The changes are well-implemented. I have one suggestion to further improve the robustness of the IAssignable implementation.

[gemini-code-assist]

The current implementation of AssignValuesOf(object other, ...) silently ignores objects that are not of type MUnique.OpenMU.PlugIns.PlugInConfiguration. This could hide bugs if an object of an unexpected type is passed. It would be more robust to throw an exception for unsupported types, which makes debugging easier and the contract of the method clearer. The suggested change preserves the behavior of doing nothing if other is null.

    public virtual void AssignValuesOf(object other, MUnique.OpenMU.DataModel.Configuration.GameConfiguration gameConfiguration)
    {
        if (other is MUnique.OpenMU.PlugIns.PlugInConfiguration typedOther)
        {
            this.AssignValuesOf(typedOther, gameConfiguration);
        }
        else if (other is not null)
        {
            throw new ArgumentException($"Cannot assign from an object of type {other.GetType().FullName}.", nameof(other));
        }
    }