Bump cmake_minimum_required to 3.5 to make conda happy #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@mgduda and @matthewhoffman, any reasons for concern here? I need this for #596, which I was hoping to merge today. |
matthewhoffman
approved these changes
Mar 31, 2025
Member
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
@xylar , I have no concerns with this, though I admit the implications of cmake version is not something I know much about.
Collaborator
Author
|
@mgduda, can you let me know if you've seen this, if you think you'd have time to review, and if so on what time scale? That would help me know how soon I can make progress on other MPAS-Tools work that this is blocking. |
Collaborator
Author
|
This seems to be a requirement of CMake >= 4.0, which was recently released. https://cmake.org/cmake/help/latest/release/4.0.html#id12 |
Collaborator
Author
|
Thanks @matthewhoffman and @mgduda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not able to build the conda package at the moment because
cmake_minimum_required < 3.5in various places. I don't think there's a strong reason that we need this minimum so I'm proposing we bump it up to what conda wants.