Conversation
fix: document cleanup logic and mock Celery task in tests & some UI fixes
…ndling - Added referral code tracking in PostHog initialization to capture initial and last seen referral codes. - Wrapped PostHog capture calls in a safeCapture function to prevent app breakage due to ad-blockers. - Introduced PostHogReferral component in PostHogProvider for improved referral tracking.
…ing for properties
…etion and improve search space filtering - Added bulk delete functionality for documents in DocumentsTableShell and DocumentsSidebar. - Enhanced search space retrieval to exclude spaces marked for deletion in read_search_spaces. - Updated connector dialog to synchronize URL parameters when opened externally. - Improved layout behavior to handle search space deletion and redirection more effectively.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 1ab5640..d960a06
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (21)
• surfsense_backend/app/routes/search_spaces_routes.py
• surfsense_backend/tests/integration/document_upload/conftest.py
• surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsTableShell.tsx
• surfsense_web/atoms/agent-tools/agent-tools.atoms.ts
• surfsense_web/atoms/chat/report-panel.atom.ts
• surfsense_web/components/assistant-ui/connector-popup.tsx
• surfsense_web/components/assistant-ui/connector-popup/connector-configs/components/composio-drive-config.tsx
• surfsense_web/components/assistant-ui/connector-popup/hooks/use-connector-dialog.ts
• surfsense_web/components/assistant-ui/thread.tsx
• surfsense_web/components/layout/providers/LayoutDataProvider.tsx
• surfsense_web/components/layout/ui/shell/LayoutShell.tsx
• surfsense_web/components/layout/ui/sidebar/ChatListItem.tsx
• surfsense_web/components/layout/ui/sidebar/DocumentsSidebar.tsx
• surfsense_web/components/layout/ui/sidebar/Sidebar.tsx
• surfsense_web/components/layout/ui/sidebar/SidebarUserProfile.tsx
• surfsense_web/components/providers/PostHogProvider.tsx
• surfsense_web/components/providers/PostHogReferral.tsx
• surfsense_web/hooks/use-documents.ts
• surfsense_web/hooks/use-google-picker.ts
• surfsense_web/instrumentation-client.ts
• surfsense_web/lib/posthog/events.ts
2 participants
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR addresses multiple UI/UX issues across the application, including fixes for dialog state management and race conditions causing unexpected closures, improvements to the connector management flow, prevention of displaying search spaces pending deletion, better handling of edge cases when spaces are deleted or users lose access, addition of bulk document deletion capabilities, restoration of the right panel's collapsed state when closing reports, improved mobile responsiveness for various components, accessibility enhancements (ARIA attributes, focus management), and addition of referral tracking via URL parameters. The changes span both backend filtering logic and frontend dialog/state synchronization.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_backend/app/routes/search_spaces_routes.pysurfsense_backend/tests/integration/document_upload/conftest.pysurfsense_web/atoms/chat/report-panel.atom.tssurfsense_web/components/assistant-ui/connector-popup.tsxsurfsense_web/components/assistant-ui/connector-popup/hooks/use-connector-dialog.tssurfsense_web/components/assistant-ui/thread.tsxsurfsense_web/components/layout/ui/sidebar/ChatListItem.tsxsurfsense_web/components/layout/ui/sidebar/Sidebar.tsxsurfsense_web/components/layout/ui/sidebar/DocumentsSidebar.tsxsurfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsTableShell.tsxsurfsense_web/hooks/use-documents.tssurfsense_web/components/layout/providers/LayoutDataProvider.tsxsurfsense_web/components/layout/ui/shell/LayoutShell.tsxsurfsense_web/components/layout/ui/sidebar/SidebarUserProfile.tsxsurfsense_web/components/assistant-ui/connector-popup/connector-configs/components/composio-drive-config.tsxsurfsense_web/atoms/agent-tools/agent-tools.atoms.tssurfsense_web/hooks/use-google-picker.tssurfsense_web/instrumentation-client.tssurfsense_web/lib/posthog/events.tssurfsense_web/components/providers/PostHogProvider.tsxsurfsense_web/components/providers/PostHogReferral.tsx