fix: document cleanup logic and mock Celery task in tests & some UI fixes#870
fix: document cleanup logic and mock Celery task in tests & some UI fixes#870MODSetter merged 6 commits intoMODSetter:devfrom
Conversation
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on eec4db4..851856a
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (8)
• surfsense_backend/tests/integration/document_upload/conftest.py
• surfsense_web/atoms/chat/report-panel.atom.ts
• surfsense_web/components/assistant-ui/connector-popup/hooks/use-connector-dialog.ts
• surfsense_web/components/assistant-ui/thread.tsx
• surfsense_web/components/layout/ui/sidebar/ChatListItem.tsx
• surfsense_web/components/layout/ui/sidebar/DocumentsSidebar.tsx
• surfsense_web/components/layout/ui/sidebar/Sidebar.tsx
• surfsense_web/components/layout/ui/sidebar/SidebarUserProfile.tsx
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR fixes document cleanup logic in the backend test suite and adds Celery task mocking for CI environments, along with several UI improvements in the web application. The backend changes ensure that document cleanup properly handles all non-200 status codes (not just 409) and mocks the Celery delete task to avoid broker dependencies during testing. The frontend changes address a race condition in the connector dialog state management, improve the report panel's right panel collapse/expand behavior, enhance the agent tools popover UI with scroll indicators and mobile responsiveness, fix dropdown menu z-index issues in the sidebar, and make various minor UI refinements including icon updates and connector display improvements.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_backend/tests/integration/document_upload/conftest.pysurfsense_web/atoms/chat/report-panel.atom.tssurfsense_web/components/assistant-ui/connector-popup/hooks/use-connector-dialog.tssurfsense_web/components/assistant-ui/thread.tsxsurfsense_web/components/layout/ui/sidebar/DocumentsSidebar.tsxsurfsense_web/components/layout/ui/sidebar/ChatListItem.tsxsurfsense_web/components/layout/ui/sidebar/Sidebar.tsxsurfsense_web/components/layout/ui/sidebar/SidebarUserProfile.tsx