fix(dfns): remove fkeys/ref; add DfnSpec.dump/s()#305
Merged
wpbonelli merged 1 commit intoMODFLOW-ORG:developfrom Apr 20, 2026
Merged
fix(dfns): remove fkeys/ref; add DfnSpec.dump/s()#305wpbonelli merged 1 commit intoMODFLOW-ORG:developfrom
wpbonelli merged 1 commit intoMODFLOW-ORG:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DfnSpec.dump()andDfnSpec.dumps()methods to serialize the full spec to a single hierarchical TOML blob. This standalone representation might be more convenient than a directory of files for some use cases. E.g., MF6 could emit the entire spec as a TOML blob (MODFLOW-ORG/modflow6#2777) for flopy to generate an MF6 module from, e.g.mf6 --spec | flopy.mf6.utils.generate_classes -Also remove the
fkeysattribute/concept (field-level foreign keys encoding subpackage attachment) andRefdataclass. Represent "floating" subpackage relationships (i.e., a subpackage may be attached to one of several possible parent components) instead via the existingDfn.subcomponentsfield, which lists the string names of component types a given component can accept as subpackages. This is simpler and more consistent with how fixed-parent hierarchy is already handled viaDfn.children. Also normalize subcomponent abbreviations to lowercase to match component name conventions elsewhere.