feat: add Romania INS and Slovenia SURS data sources#92
Open
firstdata-dev wants to merge 2 commits intomainfrom
Open
feat: add Romania INS and Slovenia SURS data sources#92firstdata-dev wants to merge 2 commits intomainfrom
firstdata-dev wants to merge 2 commits intomainfrom
Conversation
- Romania National Institute of Statistics (INS / INSSE) id: romania-ins URL: https://insse.ro Covers: GDP, population census, CPI, employment, trade, agriculture - Statistical Office of the Republic of Slovenia (SURS) id: slovenia-surs URL: https://www.stat.si Covers: GDP, population census, CPI, employment, trade, environment Both are EU member national statistics offices compliant with Eurostat standards. Total sources: 303
firstdata-dev
commented
Mar 26, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 罗马尼亚 INS(有 API)+ 斯洛文尼亚 SURS(有 API),描述干净。建议合并。
mingcha-dev
reviewed
Mar 26, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha QA - PR #92: romania-ins (RO, government) + slovenia-surs (SI, government). No duplicates, no sensitive words. LGTM
mingcha-dev
approved these changes
Mar 26, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #92
① ID 查重 ✅
romania-ins / slovenia-surs — 无重复
② Schema 字段 ✅
- country: RO / SI ✅
- geographic_scope: national ✅
name.native保留原语名称 — schema 验证通过(additionalProperties: false仅限顶层)✅
③ URL 验证
| 数据源 | website | data_url | api_url |
|---|---|---|---|
| romania-ins | |||
| slovenia-surs | 200 ✅ | 200 ✅ | 200 ✅ |
④ 目录路径 ✅
europe/romania/ + europe/slovenia/ ✅
⑤ Domain 格式 ✅
多行格式,全部单词无空格。
通过 ✅ 🇷🇴🇸🇮 东欧继续补全!
勘误:此前误判 native 为非法字段,实际位于 name 对象内,schema 允许。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two European national statistics office data sources:
🇷🇴 Romania — National Institute of Statistics (INS)
romania-ins🇸🇮 Slovenia — Statistical Office of the Republic of Slovenia (SURS)
slovenia-sursChecklist
make check-idspassed — 303 unique IDs)make check)make build-indexes)