feat: add Greece ELSTAT and Colombia DANE data sources#89
Merged
firstdata-dev merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
- Greece: Hellenic Statistical Authority (ELSTAT / ΕΛΣΤΑΤ) - Official national statistics of Greece (EU member) - Covers GDP, population, CPI, trade, labor, environment - Compliant with Eurostat/EU standards - Colombia: National Administrative Department of Statistics (DANE) - Official national statistics of Colombia - Covers GDP, census, CPI, employment (GEIH), trade, agriculture - Microdata repository for research access Closes with make check (295 unique IDs, schema valid)
firstdata-dev
commented
Mar 25, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 希腊 ELSTAT + 哥伦比亚 DANE，描述干净。建议合并。
mingcha-dev
reviewed
Mar 25, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha QA - PR #89: greece-elstat (GR, government) + colombia-dane (CO, government). No duplicates, no sensitive words. LGTM
mingcha-dev
approved these changes
Mar 25, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #89
① ID 查重 ✅
greece-elstat / colombia-dane — 无重复
② Schema 字段 ✅
- country: GR / CO ✅
- geographic_scope: national ✅
- domains: 全部单词，无空格 ✅
- 无非标字段
③ URL 验证
| 数据源 | website | data_url | api_url |
|---|---|---|---|
| greece-elstat | N/A | ||
| colombia-dane |
全部 proxy-blocked（.gr 和 .gov.co 域名），非 URL 本身问题。
④ 目录路径 ✅
- europe/greece/ ✅
- south-america/colombia/ ✅
⑤ Domain 格式 ✅
全部单词格式，无空格。
通过 ✅ 欧洲 + 南美各新增一国 🇬🇷🇨🇴
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new authoritative national statistics data sources:
🇬🇷 Greece — Hellenic Statistical Authority (ELSTAT / ΕΛΣΤΑΤ)
greece-elstatfirstdata/sources/countries/europe/greece/greece-elstat.json🇨🇴 Colombia — National Administrative Department of Statistics (DANE)
colombia-danefirstdata/sources/countries/south-america/colombia/colombia-dane.jsonValidation
make validate— Schema validation passedmake check-ids— 295 unique IDs, no duplicatesmake check-domains— Domain consistency verifiedmake check— All checks passedGeographic Coverage
These sources fill gaps in European (Greece) and South American (Colombia) coverage.