Skip to content

fix: drop the show_preview ask-first override from two challenges - #24

Merged
theycallmeswift merged 1 commit into
mainfrom
fix/drop-show-preview-override
Oct 17, 2026
Merged

theycallmeswift merged 1 commit into
mainfrom
fix/drop-show-preview-override

Conversation

@theycallmeswift

@theycallmeswift theycallmeswift commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Removes the sentence in the BirdsBirdBirds and Vibe Coding Mad Libs start-challenge skills that overrode the station's ask-first rule for show_preview. MLH/boothstrap.sh#523 (closing MLH/boothstrap.sh#507) removed that rule. Both skills still say to call show_preview "without asking first", so behavior doesn't change.

Refs MLH/boothstrap.sh#507.

Version notes:

  • The station-side change ships in the boothstrap release after v0.1.0. A station still on v0.1.0 has only the skill's own "without asking first" to go on.
  • This matters for CI here too. The root devDependency is pinned to @mlhacks/boothstrap@0.0.2, and its bundled base skill still says to call show_preview "only after the participant says yes". So boothstrap dev runs from this repo will also rely on "without asking first" alone until the pin is bumped. npm run verify doesn't check skill wording, so the pin doesn't affect CI results.

Decide

Nothing.

Ready gate

Step Evidence
Tests and lint npm run verify: all 4 packages ok. npm test: 229 pass, 0 fail. npm run lint: 0 issues in 18 files
Red run n/a: text-only change to skill prose, no behavior to fail
Sibling sweep Searched the repo outside node_modules for ask-first, overrides and without asking. The only hits were the two skill sentences, now removed, plus an unrelated overrides parameter in test/birdsbirdbirds.test.mjs. No README or test pins the wording
Docs and specs None: no doc mentions the override
Standalone run Not run. Wording-only change; the instruction to open the preview right away stays in each standalone flow
Editorial pass Reread both paragraphs against docs/style/ and rewrapped the BirdsBirdBirds lines
Skipped tests None
Secrets, permissions Not touched

Generated by Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@theycallmeswift
theycallmeswift marked this pull request as ready for review October 17, 2026 02:59
@theycallmeswift theycallmeswift self-assigned this Oct 17, 2026
@theycallmeswift
theycallmeswift merged commit 9eb1a2c into main Oct 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants