Repository navigation
fix: drop the show_preview ask-first override from two challenges - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the sentence in the BirdsBirdBirds and Vibe Coding Mad Libs
start-challengeskills that overrode the station's ask-first rule forshow_preview. MLH/boothstrap.sh#523 (closing MLH/boothstrap.sh#507) removed that rule. Both skills still say to callshow_preview"without asking first", so behavior doesn't change.Refs MLH/boothstrap.sh#507.
Version notes:
@mlhacks/boothstrap@0.0.2, and its bundled base skill still says to callshow_preview"only after the participant says yes". Soboothstrap devruns from this repo will also rely on "without asking first" alone until the pin is bumped.npm run verifydoesn't check skill wording, so the pin doesn't affect CI results.Decide
Nothing.
Ready gate
npm run verify: all 4 packages ok.npm test: 229 pass, 0 fail.npm run lint: 0 issues in 18 filesnode_modulesforask-first,overridesandwithout asking. The only hits were the two skill sentences, now removed, plus an unrelatedoverridesparameter intest/birdsbirdbirds.test.mjs. No README or test pins the wordingdocs/style/and rewrapped the BirdsBirdBirds linesGenerated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.