Skip to content

Fix varying parameters used for inferred length #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnthonyLloyd merged 2 commits into from
Sep 17, 2025
Merged

Fix varying parameters used for inferred length #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6633ac
Add flaky test for inferred length in doc string
delreluca Sep 17, 2025
73cfad0
Switch to deterministic parameter
delreluca Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion MKL.NET.WrapperGenerator.Tests/GeneratorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ public static unsafe extern void dummy(int M, int N,

generatorResult.Generator.Should().BeSameAs(generator);
generatorResult.Diagnostics.Should().BeEmpty();
generatorResult.GeneratedSources.Should().HaveCount(1);
generatorResult.GeneratedSources.Should().ContainSingle()
.Which.SourceText.ToString().Should().Contain(
"///<remarks>" +
"This version infers the length parameter <c>N</c> from <paramref name=\"A\" />'s length.</remarks>");
generatorResult.Exception.Should().BeNull();
}

Expand Down
6 changes: 3 additions & 3 deletions MKL.NET.WrapperGenerator/WrapperGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ public void Initialize(GeneratorInitializationContext context)
return candidates[0];
}

private static (ISet<ParameterSyntax> changed, ParameterListSyntax newList)
private static (IList<ParameterSyntax> changed, ParameterListSyntax newList)
TransformParameters(MethodDeclarationSyntax mds, Func<ParameterSyntax, ParameterSyntax?> f)
{
var changed = mds.ParameterList.Parameters.Select(ps => f(ps) is null ? null : ps).Where(ps => ps != null).ToImmutableHashSet();
var changed = mds.ParameterList.Parameters.Select(ps => f(ps) is null ? null : ps).Where(ps => ps != null).ToImmutableList();
var newList = SyntaxFactory.ParameterList(SyntaxFactory.SeparatedList(mds.ParameterList.Parameters.Select(ps => f(ps) ?? ps)));

return (changed!, newList);
Expand All @@ -57,7 +57,7 @@ private enum AdditionalTransformation

void WriterTransformedMethod(
MethodDeclarationSyntax mds, ClassDeclarationSyntax nativeCds,
(ISet<ParameterSyntax> changed, ParameterListSyntax newList) transformation, StringBuilder sb,
(IList<ParameterSyntax> changed, ParameterListSyntax newList) transformation, StringBuilder sb,
AdditionalTransformation trafo)
{
(ParameterSyntax lengthParam, string takeLengthFrom)? lengthOptions = null;
Expand Down
Loading