Commit ef374d0
committed
Make SENTRY_DSN an optional env var
Why these changes are being introduced:
There has long been some friction with the SENTRY_DSN env var. In a production setting
we ideally do not want an application to get deployed without the SENTRY_DSN set. At
the same time, it's really not operationally required for most applications. It's
probably the wrong ergonomics to have it checked generally and always at the config
level, when it's more of a deployed check.
How this addresses that need:
* make SENTRY_DSN optional
* issues a WARNING log message when unset or explicit "None" value
Side effects of this change:
* An application could get deployed without a SENTRY_DSN
* We can, and should, look at deploy practices that will enforce
SENTRY_DSN being present
Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-15421 parent 9c7d283 commit ef374d0
2 files changed
+9
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 12 | + | |
| 13 | + | |
17 | 14 | | |
18 | 15 | | |
19 | 16 | | |
| |||
103 | 100 | | |
104 | 101 | | |
105 | 102 | | |
106 | | - | |
| 103 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
26 | 32 | | |
27 | 33 | | |
28 | 34 | | |
| |||
0 commit comments