Skip to content

Commit 9c7d283

Browse files
committed
Revert PR template, update gitignore, and typos
1 parent fb1d654 commit 9c7d283

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

.github/pull-request-template.md

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,5 @@ YES | NO
1515
### What are the relevant tickets?
1616
- Include links to Jira Software and/or Jira Service Management tickets here.
1717

18-
### Developer
19-
- [ ] All new ENV is documented in README
20-
- [ ] All new ENV has been added to staging and production environments
21-
- [ ] All related Jira tickets are linked in commit message(s)
22-
- [ ] Stakeholder approval has been confirmed (or is not needed)
23-
24-
### Code Reviewer(s)
25-
- [ ] The commit message is clear and follows our guidelines (not just this PR message)
26-
- [ ] There are appropriate tests covering any new functionality
27-
- [ ] The provided documentation is sufficient for understanding any new functionality introduced
28-
- [ ] Any manual tests have been performed and verified
29-
- [ ] New dependencies are appropriate or there were no changes
18+
### Code review
19+
* Code review best practices are documented [here](https://mitlibraries.github.io/guides/collaboration/code_review.html) and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,5 +138,6 @@ dmypy.json
138138
# jetbrains
139139
.idea/
140140

141+
.arch_tag
141142
.aws-sam/
142143
tests/sam/env.json

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ Response:
9898

9999
Note: the lambda is still returning a dictionary that _would_ work for an HTTP response, but when invoked directly it's just a dictionary with the relevant information.
100100

101-
### Troubleshoot
101+
### Troubleshooting
102102

103103
#### Encounter error `botocore.exceptions.TokenRetrievalError`
104104

0 commit comments

Comments
 (0)