fix: include wbc_max in SIRS WBC missing-data guard - #2146
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Chessing234
force-pushed
the
fix/sirs-wbc-max-null-guard
branch
from
August 5, 2026 10:32
37b38f6 to
ff7517b
Compare
WBC scoring uses wbc_min, wbc_max, and bands_max, but the null arm only checked coalesce(wbc_min, bands_max), so a present wbc_max alone yielded NULL instead of 0. Align the guard across BigQuery, Postgres, and DuckDB.
Chessing234
force-pushed
the
fix/sirs-wbc-max-null-guard
branch
from
August 9, 2026 13:39
ff7517b to
4a1cd36
Compare
alistairewj
approved these changes
Aug 9, 2026
alistairewj
left a comment
alistairewj
left a comment
Member
There was a problem hiding this comment.
this change is a no-op because wbc_min and wbc_max are always null/not-null together - please try to avoid PRs which "fix" surface level issues that do not actually appear in the data
Member
|
needs rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wbc_min,wbc_max, andbands_max, but the missing-data arm only checkedCOALESCE(wbc_min, bands_max).wbc_maxis present (and normal), the CASE fell through to NULL instead of 0.Test plan
wbc_min/bands_maxand present normalwbc_max→wbc_score = 0wbc_scoreremains NULLwbc_max/ lowwbc_min/ highbands_maxstill score 1Made with Cursor