Fix SOFA CV scoring, urine_output_rate diffs, and Elixhauser no_drg - #2126
Open
Chessing234 wants to merge 7 commits into
Open
Fix SOFA CV scoring, urine_output_rate diffs, and Elixhauser no_drg#2126Chessing234 wants to merge 7 commits into
Chessing234 wants to merge 7 commits into
Conversation
Contributor
Author
This was referenced Jul 25, 2026
Contributor
Author
|
Concept changes from the old mega-PR are landing here / in follow-ups; load-path/transpile/CI moved to #2127. |
1 task
Contributor
Author
|
SQLFluff itself is fine — the red check was the annotate action lacking fork permissions. Pulled in the same ignore-unauthorized-error fix as #2128. |
Chessing234
force-pushed
the
fix/sofa-cv-and-uo-rate
branch
from
August 5, 2026 10:34
4f44397 to
0f69ed0
Compare
fork annotate fix lives in MIT-LCP#2148
Contributor
Author
|
dropped the continue-on-error sqlfluff hunk — that's in #2148 now. this one is concept-only again (sofa cv, uo rate, elixhauser). @alistairewj ready for review when you have a minute. |
same fix as MIT-LCP#2148 — skip annotate when head repo is a fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urine_output_rateuses second-based DATETIME_DIFF so BigQuery and Postgres agree (DATETIME_DIFFimplementation varies between postgres and bigquery #1549)elixhauser_ahrq_v37_no_drg.sql#1077)Test plan
pytest tests/for changed concepts (sqlfluff + transpile)Made with Cursor