Add heterogeneous reacting surface boundary conditions - #1821
Open
rocfire11 wants to merge 3 commits into
Open
Conversation
rocfire11
force-pushed
the
carbon-surface-v1
branch
from
September 4, 2026 19:54
4a71f17 to
5b4999a
Compare
Lines of Code
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1821 +/- ##
==========================================
- Coverage 62.26% 61.79% -0.47%
==========================================
Files 84 84
Lines 21558 21745 +187
Branches 3195 3214 +19
==========================================
+ Hits 13423 13438 +15
- Misses 5937 6106 +169
- Partials 2198 2201 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Policy
We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.
All contributions are expected to demonstrate:
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.
Acknowledgement
PR template credit: junegunn
Summary
This PR adds heterogeneous reacting surface boundary conditions for immersed
boundaries. The implementation was developed for reacting carbon-particle
simulations in which heterogeneous surface chemistry is coupled to the
compressible gas-phase species equations.
The surface treatment supports:
thermal_bc = 0)thermal_bc = 1)thermal_bc = 2)surface_cantera_fileandsurface_phaseFor a reacting surface, the species boundary condition balances diffusive
transport, Stefan mass flux, and heterogeneous surface production. One species
equation is replaced by the mass-fraction closure. When
thermal_bc = 2, thesurface temperature is included as an additional Newton unknown and the
conductive and heterogeneous reaction heat fluxes are balanced.
Motivation
The immediate application is heterogeneous oxidation/gasification of carbon
particles using an immersed-boundary representation. The implementation is
intended to remain general with respect to the number of gas species and the
Cantera surface mechanism rather than hard-coding a particular carbon
mechanism.
Testing
I have tested the implementation with the Kestel/Libby-Blake three-reaction
carbon surface mechanism using:
Both prescribed-temperature and coupled-energy carbon cases run successfully
and produce the expected surface reaction products, oxygen consumption,
thermal field, and reacting wake.
The branch was rebased from current MFC master before the surface changes were
introduced, and
./mfc.sh precheckand the simulation build pass.