Skip to content

ci: keep build/venv when the build retry nukes the build directory #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbryngelson wants to merge 2 commits into from
+11 −5
Closed

ci: keep build/venv when the build retry nukes the build directory #1814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1f453
ci: keep build/venv when the build retry nukes the build directory
sbryngelson Sep 3, 2026
608e137
ci: say what the build retry clears, and pass -- to rm
sbryngelson Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/scripts/retry-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
# Provides retry_build(): 2-attempt loop.
# On failure of attempt 1, nukes the entire build directory before attempt 2.
# On failure of attempt 1, nukes the build directory before attempt 2, keeping
# build/venv: a compute node cannot reinstall it (no route to PyPI), and a
# failed reinstall is misread as a cluster-wide outage (#1813).
# If RETRY_VALIDATE_CMD is set, runs it after a successful build; a non-zero
# exit triggers the same nuke-and-retry, catching e.g. SIGILL from binaries
# compiled on a different CPU architecture.
Expand All @@ -12,6 +14,10 @@
# path without waiting on it; CI leaves it at the default.
: "${MFC_BUILD_RETRY_DELAY:=30}"

nuke_build() {
find build -mindepth 1 -maxdepth 1 ! -name venv -exec rm -rf -- {} + 2>/dev/null || true
}

retry_build() {
local max_attempts=2
local validate_cmd="${RETRY_VALIDATE_CMD:-}"
Expand All @@ -23,8 +29,8 @@ retry_build() {
if ! eval "$validate_cmd"; then
echo "Post-build validation failed on attempt $attempt."
if [ $attempt -lt $max_attempts ]; then
echo " Nuking build directory before retry..."
rm -rf build 2>/dev/null || true
echo " Clearing the build directory (keeping build/venv) before retry..."
nuke_build
sleep 5
attempt=$((attempt + 1))
continue
Expand All @@ -38,8 +44,8 @@ retry_build() {
return 0
fi
if [ $attempt -lt $max_attempts ]; then
echo " Build failed — nuking build directory before retry..."
rm -rf build 2>/dev/null || true
echo " Build failed — clearing the build directory (keeping build/venv) before retry..."
nuke_build
sleep "$MFC_BUILD_RETRY_DELAY"
else
echo "Build failed after $max_attempts attempts."
Expand Down
Loading