Modify CLAUDE code review workflow for PR handling#1354
Conversation
Updated the workflow to fetch the PR branch and adjusted checkout depth.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Claude Code Review Head SHA: 1ced066 Files changed:
Findings: Fork PR support broken by The new "Fetch PR branch" step runs: git fetch origin "$PR_HEAD_REF"For PRs opened from forks, The correct ref to fetch for any PR (including forks) is the GitHub-managed pull request ref: git fetch origin "refs/pull/${{ steps.mode.outputs.pr_number }}/head"This ref is always present in |
|
@claude full review |
|
Claude Code is working… I'll analyze this and get back to you. |
Review Summary by QodoRefactor PR checkout and branch fetching workflow
WalkthroughsDescription• Restructured PR checkout workflow to fetch PR branch explicitly • Added dynamic PR head reference detection using GitHub CLI • Increased git fetch depth from 1 to 0 for complete history • Removed positive confirmation guideline from code review instructions Diagramflowchart LR
A["Determine PR number"] --> B["Fetch PR head reference via gh CLI"]
B --> C["Checkout base repo with full depth"]
C --> D["Fetch PR branch explicitly"]
D --> E["Resolve review state"]
F["Remove positive confirmation guideline"] -.-> E
File Changes1. .github/workflows/claude-code-review.yml
|
Code Review by Qodo
1. Fork PR fetch breaks
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| PR_HEAD_REF="$(gh pr view "$PR_NUMBER" --repo "${{ github.repository }}" --json headRefName --jq .headRefName)" | ||
|
|
||
| echo "pr_number=$PR_NUMBER" >> "$GITHUB_OUTPUT" | ||
| echo "pr_head_ref=$PR_HEAD_REF" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Checkout base repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Fetch PR branch | ||
| shell: bash | ||
| env: | ||
| PR_HEAD_REF: ${{ steps.mode.outputs.pr_head_ref }} | ||
| run: | | ||
| set -euo pipefail | ||
| git fetch origin "$PR_HEAD_REF" |
There was a problem hiding this comment.
1. Fork pr fetch breaks 🐞 Bug ☼ Reliability
The workflow computes PR_HEAD_REF using only headRefName and then runs `git fetch origin "$PR_HEAD_REF", which only works if the PR head branch exists on the origin` remote (the checked-out base repo). For PRs where the head branch is not on origin, this step fails under `set -euo pipefail` and prevents any review from being published.
Agent Prompt
### Issue description
The workflow fetches the PR head branch by name from `origin`, but `origin` is the base repo. This fails when the PR’s head branch is not present on `origin`, causing the job to abort.
### Issue Context
This job runs on `pull_request_target`, checks out the base repo, and then tries to fetch the PR branch.
### Fix Focus Areas
- .github/workflows/claude-code-review.yml[61-77]
### Suggested fix
Prefer fetching the PR head via GitHub’s pull refs (works regardless of fork), e.g. use the PR number:
- Replace the `headRefName`-based fetch with something like:
- `git fetch origin "refs/pull/$PR_NUMBER/head:refs/remotes/origin/pr/$PR_NUMBER"`
- Or remove the fetch entirely if nothing downstream actually needs local git refs.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
2 participants
fix claude reviewer