Performance improvements#24
Open
nicholasgower wants to merge 1 commit into
Open
Conversation
…rformance by factor of 30 on idle and by factor of 10 when gui is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On idle, this mod consumes about 0.03 ms/tick on my computer and about 0.1 ms/tick with a gui open. After replacing the on_tick event with an on_nth_tick event running every 60 ticks, I reduced passive performance cost to ~0.002 ms/tick and ~0.003-0.01 ms/tick with a gui open. While I'm sure responsiveness is slightly impacted when using highly mixed belts with many rapidly changing ingredients, I don't think this is a typical use of this mod, and the persistence of only updating the gui every second makes up for this disadvantage.