Skip to content

Improvement - Add TransferModule#ping validation & increase PingRequest timeout to 10s#302

Open
ItsNature wants to merge 1 commit into
version/1.2.9from
improvement/transfer-ping
Open

Improvement - Add TransferModule#ping validation & increase PingRequest timeout to 10s#302
ItsNature wants to merge 1 commit into
version/1.2.9from
improvement/transfer-ping

Conversation

@ItsNature

@ItsNature ItsNature commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Overview

Description:
Fixes the server ping round-trip failing whenever a request contains an unreachable address. The client pings every address and reports unreachable ones as TIMED_OUT. Additionally, requests with more than 10 server IPs were silently dropped by the client and only surfaced as a generic timeout.

Changes:

  • PingRequest overrides the timeout to 10s, giving ping round-trips the headroom they need.
  • TransferModuleImpl#ping now fails fast with IllegalArgumentException when the request contains no server IPs or more than TransferModule.MAX_PINGS_PER_PACKET (10), instead of sending a request the client can't honor.

Review Request Checklist

  • Your code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have tested this change myself. (If applicable)
  • I have made corresponding changes to the documentation. (If applicable)
  • The branch name follows the projects naming conventions. (e.g. feature/add-module & bugfix/fix-issue)

@ItsNature ItsNature added type: Documentation Documentation improvement or issue type: Enhancement Feature improvement or addition labels Jul 12, 2026
@ItsNature ItsNature changed the title Improvement - Add TransferModule#ping validation & increase PingRequest timeout to 10s` Improvement - Add TransferModule#ping validation & increase PingRequest timeout to 10s Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Documentation Documentation improvement or issue type: Enhancement Feature improvement or addition

Development

Successfully merging this pull request may close these issues.

3 participants