fix: use toolchain file while building dependencies#281
fix: use toolchain file while building dependencies#281LtdSauce wants to merge 1 commit intoLukeMathWalker:mainfrom
Conversation
This commit make the cargo build command that builds the dependencies actually adhere to the toolchain file if it was present in the recipe. Before this it was ignored and thus the next call to cargo build would rebuild all dependencies again, but then with what is actually contained in the toolchain file. This was because the environment variable 'RUSTUP_TOOLCHAIN' was already set and so the toolchain file was not considered, see here for details: https://rust-lang.github.io/rustup/overrides.html
|
Hi! I have not found tests, that actually check the cargo invokation and thus did not add any tests for this. This could be reproduced using any recipe that contains a toolchain, that uses a different channel/version than what is installed by default. I used the following for example: |
|
Coming back to this way too late, nonetheless: I don't think this is the right approach. Based on my current understanding, we're already doing the right thing here: we restore the toolchain file and then let I'll close this, but feel free to re-open if my reasoning is incorrect. |
This commit make the cargo build command that builds the dependencies actually adhere to the toolchain file if it was present in the recipe.
Before this it was ignored and thus the next call to cargo build would rebuild all dependencies again, but then with what is actually contained in the toolchain file. This was because the environment variable 'RUSTUP_TOOLCHAIN' was already set and so the toolchain file was not considered, see here for details:
https://rust-lang.github.io/rustup/overrides.html
This should fix #271 (and also solve the missing piece for #231)