replace all spaces in group/track names and not just the first one#468
Open
BNTFryingPan wants to merge 1 commit intoLuckPerms:masterfrom
Open
replace all spaces in group/track names and not just the first one#468BNTFryingPan wants to merge 1 commit intoLuckPerms:masterfrom
BNTFryingPan wants to merge 1 commit intoLuckPerms:masterfrom
Conversation
✅ Deploy Preview for luckperms ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
preview: luckperms-webeditor-spaces-fix.mp4 |
Member
|
|
Member
Author
|
|
This was referenced Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes LuckPerms/LuckPerms#3865
String.prototype.replace()in JavaScript only replaces the first occurrence when the first argument provided is a string. If text with multiple spaces was pasted into the box, only the first one would get replaced. This PR replaces the" "with a global regex/ /gso all occurrences will get replaced.