added support for colors and styles for displayName in editor#390
added support for colors and styles for displayName in editor#390DesignDeveloperr wants to merge 1 commit intoLuckPerms:masterfrom
Conversation
DesignDeveloperr
commented
Dec 15, 2021

|
✔️ Deploy Preview for luckperms ready! 🔨 Explore the source changes: 5d1791e 🔍 Inspect the deploy log: https://app.netlify.com/sites/luckperms/deploys/61b9c904d74e4c0007f453c7 😎 Browse the preview: https://deploy-preview-390--luckperms.netlify.app/ |
|
Hi, thanks for this! We had a chat in Discord about the changes, @Turbotailz had some concerns about using I think the best way to deal with the problem is to just use Vue components instead of separately generated HTML, what do you think? @Turbotailz any other ideas? |
|
I'd just like to note that my PR is related to #103, which also suggests coloring prefixes and suffixes, which is the problem with my implementation (figuring out how far we shall parse prefixes/suffixes). Also: this PR does not support hex color codes, which I think would be an important feature. Or maybe I just haven't spotted it yet? |
|
Yeah, while I appreciate the PR, I am not too comfortable with the amount of DOM manipulation being done, along with the usage of And as Tobi says, it doesn't support hex codes which seems to be all the rage these days. I can just see it now - all the people asking about support for that 😅 If we support original colour codes, we need to support hex as well. |
|
I don't like this because it makes assumptions about how displayName will be interpreted. For example, I could have a plugin that interprets it as text component JSON, or even MiniMessage. Should LuckPerms support all of those, and if so, how would I select between them? |