Skip to content

Made the hardcoded completion field limit configurable #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
+3 −1
Draft

Made the hardcoded completion field limit configurable #3298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a627ad
Made the hardcoded completion field limit configurable
halflifefan Nov 30, 2025
2061df5
Merge branch 'master' into max-fields-count
halflifefan Dec 1, 2025
04121f5
Merge branch 'master' into max-fields-count
halflifefan Dec 1, 2025
ef1adbd
Merge branch 'master' into max-fields-count
halflifefan Dec 1, 2025
e1dd213
Merge branch 'master' into max-fields-count
halflifefan Dec 1, 2025
37ed3e4
Merge branch 'master' into max-fields-count
sumneko Dec 2, 2025
0956873
Merge branch 'master' into max-fields-count
sumneko Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions script/config/template.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ local template = {
'Disable',
},
['Lua.completion.autoRequire'] = Type.Boolean >> true,
['Lua.completion.maxFieldCount'] = Type.Integer >> 100,
['Lua.completion.showParams'] = Type.Boolean >> true,
['Lua.completion.requireSeparator'] = Type.String >> '.',
['Lua.completion.postfix'] = Type.String >> '@',
Expand Down
3 changes: 2 additions & 1 deletion script/core/completion/completion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,9 @@ local function checkFieldOfRefs(refs, state, word, startPos, position, parent, o
local fields = {}
local funcs = {}
local count = 0
local maxFieldCount = config.get(state.uri, 'Lua.completion.maxFieldCount')
for _, src in ipairs(refs) do
if count > 100 then
if count > maxFieldCount then
results.incomplete = true
break
end
Expand Down
Loading