fix(settings): Allow re-editing RetroAchievements username/password#652
Open
clintonium-119 wants to merge 2 commits intoLoveRetro:mainfrom
Open
fix(settings): Allow re-editing RetroAchievements username/password#652clintonium-119 wants to merge 2 commits intoLoveRetro:mainfrom
clintonium-119 wants to merge 2 commits intoLoveRetro:mainfrom
Conversation
Reset KeyboardPrompt state when opening the input dialog so users can edit username/password multiple times without restarting settings.elf.
TextInputMenuItem::handleInput was not setting dirty flag after on_confirm, so the keyboard prompt never triggered a redraw on the frame it opened. Additionally, handleKeyboardInput was clobbering the pending redraw flag set by setInitialText. Together these caused a 1-3s delay until the user happened to press another button.
Author
|
I also fixed the delay issue when opening RetroAchievements username and password text input TextInputMenuItem::handleInput was not setting dirty flag after Additionally, handleKeyboardInput was clobbering the Or so Claude tells me.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset KeyboardPrompt state when opening the input dialog so users can edit username/password multiple times without restarting settings.elf.