sd: sync with master-758-c674225#2310
Open
wbruna wants to merge 5 commits into
Open
Conversation
2fbadf7 to
0591d74
Compare
Author
|
I've changed the internal C++ API to keep it more aligned with upstream, moving the backend, params and max_vram selection logic to the Python level; so we may enable the multi-device support without additional API logic. |
0591d74 to
1baeac6
Compare
1baeac6 to
92e2c35
Compare
c27fedb to
fddb731
Compare
Author
|
The denoise strength tweak would be a welcome addition for image to image mode, since it avoids the step count lowering when reducing the strength; except it deviates from the auto1111 api behavior 😕 Although I'm not sure if the 'send as refimg' toggle isn't breaking compatibility already (if it is, an approach could be making it a tri-state strength-as-step-count / strength-as-noise-level / strength-ignored-for-ref-image). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master-749-b11c95a: