Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/add_identifiers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
run: bundle exec fastlane identifiers
env:
TEAMID: ${{ secrets.TEAMID }}
TEAMID_SUFFIX: ${{ vars.TEAMID_SUFFIX }}
GH_PAT: ${{ secrets.GH_PAT }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
FASTLANE_KEY_ID: ${{ secrets.FASTLANE_KEY_ID }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_loop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ jobs:
run: bundle exec fastlane build_loop
env:
TEAMID: ${{ secrets.TEAMID }}
TEAMID_SUFFIX: ${{ vars.TEAMID_SUFFIX }}
GH_PAT: ${{ secrets.GH_PAT }}
FASTLANE_KEY_ID: ${{ secrets.FASTLANE_KEY_ID }}
FASTLANE_ISSUER_ID: ${{ secrets.FASTLANE_ISSUER_ID }}
Expand All @@ -246,6 +247,7 @@ jobs:
run: bundle exec fastlane release
env:
TEAMID: ${{ secrets.TEAMID }}
TEAMID_SUFFIX: ${{ vars.TEAMID_SUFFIX }}
GH_PAT: ${{ secrets.GH_PAT }}
FASTLANE_KEY_ID: ${{ secrets.FASTLANE_KEY_ID }}
FASTLANE_ISSUER_ID: ${{ secrets.FASTLANE_ISSUER_ID }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/create_certs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on: [workflow_call, workflow_dispatch]

env:
TEAMID: ${{ secrets.TEAMID }}
TEAMID_SUFFIX: ${{ vars.TEAMID_SUFFIX }}
GH_PAT: ${{ secrets.GH_PAT }}
GH_TOKEN: ${{ secrets.GH_PAT }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/validate_secrets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
FASTLANE_KEY: ${{ secrets.FASTLANE_KEY }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
TEAMID: ${{ secrets.TEAMID }}
TEAMID_SUFFIX: ${{ vars.TEAMID_SUFFIX }}
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down Expand Up @@ -141,6 +142,17 @@ jobs:
echo "::error::The TEAMID secret is set but invalid. Verify that it is set correctly (only uppercase letters and numbers) and try again."
fi

# Validate TEAMID_SUFFIX
if [ -z "$TEAMID_SUFFIX" ]; then
echo "::notice::No TEAMID_SUFFIX variable is set."
elif [ ${#TEAMID_SUFFIX} -gt 5 ]; then
failed=true
echo "::error::The TEAMID_SUFFIX variable is set but is too long. Verify that it the length is between 1 and 5 characters and try again."
elif ! [[ $TEAMID_SUFFIX =~ ^[A-Z0-9]+$ ]]; then
failed=true
echo "::error::The TEAMID_SUFFIX variable is set but invalid. Verify that it is set correctly (only uppercase letters and numbers) and try again."
fi

# Validate MATCH_PASSWORD
if [ -z "$MATCH_PASSWORD" ]; then
failed=true
Expand Down
3 changes: 2 additions & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

default_platform(:ios)

TEAMID = ENV["TEAMID"]
TEAMID = ENV["TEAMID_SUFFIX"].to_s.empty? ? "#{ENV["TEAMID"]}" : "#{ENV["TEAMID"]}-#{ENV["TEAMID_SUFFIX"]}"
GH_PAT = ENV["GH_PAT"]
GITHUB_WORKSPACE = ENV["GITHUB_WORKSPACE"]
GITHUB_REPOSITORY_OWNER = ENV["GITHUB_REPOSITORY_OWNER"]
Expand Down Expand Up @@ -123,6 +123,7 @@ platform :ios do
configuration: "Release",
destination: 'generic/platform=iOS',
buildlog_path: 'buildlog'
xcargs: "MAIN_APP_BUNDLE_IDENTIFIER=com.#{TEAMID}.loopkit.Loop"
)

copy_artifacts(
Expand Down