Let cell edit mode use the configured font (#720) - #721
Merged
Merged
Conversation
RowsDefaultCellStyle hardcoded Courier New 8.25pt, overriding the configured font kept in DefaultCellStyle, so the cell editing control (double-click / Ctrl+E) ignored it. The row style no longer sets a font and inherits it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #720.
PaintHelper.GetDataGridDefaultRowStylehardcoded Courier New 8.25pt. AsRowsDefaultCellStyleit takes precedence overDefaultCellStyle, whichLogWindow.PreferencesChangedkeeps at the configured font, so the cell editing control (double-click / Ctrl+E) in the log and filter grid always showed Courier New. The row style no longer sets a font and inherits it fromDefaultCellStyle.PaintHelperTests(failed before: Courier New 8.25 instead of the grid font).GetDataGridViewCellStyle/ Current line highlight #85 TODO, and other Courier New usages.