Fix InvalidOperationException when resizing the filter splitter on a …#642
Merged
Conversation
…narrow window Double-clicking or dragging the filter row's splitter while the LogExpert window is narrower than ~730px threw: InvalidOperationException: SplitterDistance must be between Panel1MinSize and Width - Panel2MinSize at SplitContainer.set_SplitterDistance at LogWindow.AutoResizeFilterBox The #560 fix set filterSplitContainer.Panel2MinSize = 726. Under Dock=Fill the parent layout engine forces the container below Panel1MinSize + SplitterWidth + Panel2MinSize, so no splitter distance can honour both minimums. The setter throws (it does not clamp) when handed a value that can't fit, and the old ClampSplitterDistance returned Panel1MinSize anyway via Math.Max. Replace ClampSplitterDistance with TryClampSplitterDistance, which returns false when both minimums can't fit. AutoResizeFilterBox and OnFilterSplitContainerMouseMove now skip the assignment in that degenerate state, leaving the splitter put. Tests ported to the Try form plus a regression case pinning the crash geometry (Width 684, Panel2MinSize 726).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…narrow window
Double-clicking or dragging the filter row's splitter while the LogExpert window is narrower than ~730px threw:
InvalidOperationException:
SplitterDistance must be between Panel1MinSize and Width - Panel2MinSize at SplitContainer.set_SplitterDistance at LogWindow.AutoResizeFilterBox
The #560 fix set filterSplitContainer.Panel2MinSize = 726. Under Dock=Fill the parent layout engine forces the container below Panel1MinSize + SplitterWidth + Panel2MinSize, so no splitter distance can honour both minimums. The setter throws (it does not clamp) when handed a value that can't fit, and the old ClampSplitterDistance returned Panel1MinSize anyway via Math.Max.
Replace ClampSplitterDistance with TryClampSplitterDistance, which returns false when both minimums can't fit. AutoResizeFilterBox and OnFilterSplitContainerMouseMove now skip the assignment in that degenerate state, leaving the splitter put.
Tests ported to the Try form plus a regression case pinning the crash geometry (Width 684, Panel2MinSize 726).