fix(acp): route Factory Droid through direct ACP - #367
Open
specter119 wants to merge 1 commit into
Open
Conversation
Model: gpt-5.6-luna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #366
Problem / pressure
Factory Droid's
acp-daemonmode fails during ACPsession/newwhenever Lody includes a stdio MCP server. The daemon injects an unsupported--mcp-serversargument into its inner Droid process, which exits with code 1 and is surfaced as-32603 Internal error. This blocks the normal MCP-enabled Factory Droid workflow.Summary
droid@0.211.0npx registry entry that launches directacpwith auto-update disabled.Before / after
droid@0.208.2 exec --output-format acp-daemon; with a non-emptysession/new.mcpServers, the daemon launched a child with unsupported--mcp-serversarguments and ACP returned-32603.droid@0.211.0 exec --output-format acp; MCP configuration remains in the ACPsession/new.mcpServersrequest and session initialization succeeds.Test plan
acp-daemonfailed and directacpsucceeded on both Droid0.208.2and0.211.0.apps/cli/tests/agent-setting.test.ts: 30 tests passed.tsgo --noEmit: passed.node scripts/check-public-boundary.mjs: passed.git diff --check: passed..github/scripts/check-pr-body.mjs: passed.Context handoff
Instructions for reviewing agents
acp-daemonis the correct compatibility boundary and that keeping MCP insession/new.mcpServerspreserves the intended protocol contract.Authoring context
0.211.0, disable its auto-update path, and select directacpso Lody does not enter the daemon's unsupported child-argument bridge.--mcp-serversargument. The remaining uncertainty is future compatibility if Droid changes its ACP CLI contract.