feat(auth): add origin-bound saved-credential challenges - #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AUTH_REQUIREDchallenges with exact-origin aliasesauth login --interactivewith native secure macOS input and foreground/dev/ttyinput on LinuxSecurity
Verification
pnpm testpnpm test:runtimepnpm test:npmpnpm buildpnpm test:e2e:macgit diff --checkpnpm audit --prod: no known vulnerabilitiesLocal Linux Docker E2E could not run because Docker Desktop's daemon was non-responsive. GitHub CI provides the independent Linux gate.
Scope
This completes the trusted interactive CLI/native save-consent path. Private in-memory credentials remain in #35. The Settings window remains in #158, and any future agent-deferred save offer must preserve the same trusted user-authorization boundary.
Depends on #177.