Skip to content

fix(macos): move Pin off Cmd-P and test menu chords - #174

Open
yashranaway wants to merge 1 commit into
mainfrom
feat/macos-shortcuts
Open

fix(macos): move Pin off Cmd-P and test menu chords#174
yashranaway wants to merge 1 commit into
mainfrom
feat/macos-shortcuts

Conversation

@yashranaway

Copy link
Copy Markdown
Collaborator

Summary

Implements the unblocked part of #160.

  • Menu chords are a catalog in `MenuShortcuts.swift`. The Cocoa host applies that catalog instead of hard-coding modifiers in `buildMenu()`.
  • Pin on Top is Cmd-Option-P. Cmd-P is no longer taken from Print.
  • Snapshot stays Cmd-Shift-S on purpose.
  • Cmd-, is not wired. Settings (macOS Settings window: shared preferences UI and Cmd+, shortcut #158) is parked.
  • Protocol suite rejects duplicate chords and checks the Pin/snapshot/Settings reservations. P0 documents the chords.

Full GUI E2E of every menu item still wants a macOS session. The collision contract is tested without one.

Closes #160

Pin on Top is now Cmd-Option-P. Shortcuts live in a portable catalog so
the protocol suite can reject collisions, including a reserved Cmd-,.
@yashranaway yashranaway self-assigned this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS shortcuts: audit collisions and test menu behavior

1 participant