fix(windows): initialize COM on audio threads - #5603
Open
n1net4il wants to merge 3 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
On some Windows environments, as observed in a VMware Windows 11 guest, audio initialization could fail because the existing code did not guarantee that COM was initialized on the audio worker thread before accessing WASAPI COM interfaces.
0x800401F0corresponds toCO_E_NOTINITIALIZED, indicating that COM was not initialized on the calling thread.This change ensures that COM is initialized on the Windows audio worker thread before audio policy and WASAPI operations, and keeps it initialized for the thread’s lifetime. It also handles existing COM apartments safely, balances successful initialization calls with
CoUninitialize(), and adds unit tests for the relevant HRESULT cases.AI tools assisted with identifying the root cause and developing the patch. The fix was manually verified in the original VMware Windows 11 reproduction environment.
Successful audio initialization after applying the patch:
References
Screenshot
Issues Fixed or Closed
Fixes #4847
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.