refactor: basic widgets to widget3#7482
Open
ElectricalBoy wants to merge 35 commits into
Open
Conversation
hjpalpha
approved these changes
May 11, 2026
Rathoz
reviewed
May 11, 2026
Rathoz
reviewed
May 11, 2026
Rathoz
reviewed
May 11, 2026
Rathoz
reviewed
May 11, 2026
ElectricalBoy
force-pushed
the
basic-widgets-to-widget3
branch
2 times, most recently
from
c58d5ad to
32bb3c4
Compare
ElectricalBoy
force-pushed
the
basic-widgets-to-widget3
branch
from
062892a to
2937b0e
Compare
Rathoz
reviewed
May 13, 2026
Comment on lines
+17
to
+21
| ---@class HtmlNodeProps | ||
| ---@field classes? string[] | ||
| ---@field css? table<string, string|number?> | ||
| ---@field attributes? table<string, string|number?> | ||
| ---@field children? Renderable|Renderable[] |
Collaborator
There was a problem hiding this comment.
Let's use a multi-line alias instead, so we are consistent between alias and class (as they behave differently)
Collaborator
Author
There was a problem hiding this comment.
there are few places like the above two that simply extend HtmlNodeProps to save some duplicate code
Rathoz
reviewed
May 13, 2026
Collaborator
There was a problem hiding this comment.
This one can't be done until defaultProps fromTemplate combo is fixed. Can you check if any others needs that too?
Collaborator
Author
There was a problem hiding this comment.
there are 7 widgets in this PR that use defaultProps
- dropdown/container
- dropdown/item
- button
- carousel
- datatable
- link
- iconimage
afaik button is the only one using widget/factory entrypoint; we could either get #7478 deployed first or defer button migration. Adding temporary workaround like #7477 is an option too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test this change?
preview with dev