Skip to content

refactor(squad): use widget3 and general refactor#7425

Merged
Rathoz merged 28 commits into
mainfrom
squad-refactor
May 12, 2026
Merged

refactor(squad): use widget3 and general refactor#7425
Rathoz merged 28 commits into
mainfrom
squad-refactor

Conversation

@Rathoz
Copy link
Copy Markdown
Collaborator

@Rathoz Rathoz commented Apr 21, 2026

Summary

Major refactor of Squads in general, to be more clean. Done as an extended part of Widget3 in reality implementation.

Moves dota2 custom field into core. Remove OW custom field as it is no longer used on that wiki. Removed some SC1 stuff, as it's been broken for a while and no1 has complained. Moved Smash display stuff to Smash Opponent Display

How did you test this change?

dev

@Rathoz Rathoz changed the title refactor(squad): use widget3 and refactor rows refactor(squad): use widget3 and general refactor Apr 21, 2026
@Rathoz Rathoz changed the base branch from widget30 to widget3-table2 April 22, 2026 08:08
Comment thread lua/wikis/commons/Components/Contexts/Squad.lua Outdated
Comment thread lua/wikis/commons/Components/Squad/Container.lua Outdated
Comment thread lua/wikis/commons/Components/Squad/Header.lua Outdated
Comment thread lua/wikis/commons/Components/Squad/Player.lua Outdated
Comment thread lua/wikis/commons/Squad/Utils.lua Outdated
@Rathoz Rathoz force-pushed the widget3-table2 branch from 9201659 to 697648d Compare May 4, 2026 14:49
@Rathoz Rathoz force-pushed the squad-refactor branch from 83d11ce to a6606a5 Compare May 4, 2026 15:17
@Rathoz Rathoz force-pushed the widget3-table2 branch from 7cc64fc to 57af813 Compare May 7, 2026 08:59
@Rathoz Rathoz force-pushed the squad-refactor branch from 349b7e0 to a5e8cc5 Compare May 7, 2026 09:02
Base automatically changed from widget3-table2 to main May 11, 2026 11:30
@Rathoz Rathoz marked this pull request as ready for review May 11, 2026 12:06
@Rathoz Rathoz requested a review from a team as a code owner May 11, 2026 12:06
Copilot AI review requested due to automatic review settings May 11, 2026 12:06
@Rathoz Rathoz requested a review from a team as a code owner May 11, 2026 12:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Squad table rendering to a widget3/component-based implementation, introducing a shared Squad/Controller and new squad table components, and migrating some wiki-specific squad customizations to use the new flow.

Changes:

  • Introduce Module:Squad/Controller and new widget3 squad components (Widget/Squad/{Container,Header,Player}) and rewire commons + some wikis to use them.
  • Replace the legacy squad widget/row implementation (Widget/Squad/Core*, Squad/Row) and older context system usage in Widget/Contexts/Squad.
  • Remove wiki-specific squad custom modules for Overwatch and Dota 2; refactor Smash and StarCraft II custom squad modules.

Reviewed changes

Copilot reviewed 15 out of 24 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
lua/wikis/starcraft2/Squad/Custom.lua Switch SC2 squad rendering to Squad/Controller and add LPDB adjustment hook for grouping.
lua/wikis/smash/Squad/Custom.lua Wrap squad rendering with a new GameTitle component context and delegate to Squad/Controller.
lua/wikis/smash/Opponent/Custom.lua Add CustomOpponent.resolve() to sync player character mains via LPDB when syncPlayer is enabled.
lua/wikis/overwatch/Squad/Custom.lua Delete Overwatch custom squad implementation (previously added “Number” column behavior).
lua/wikis/dota2/Squad/Custom.lua Delete Dota 2 custom squad implementation (previously added “Active Team” behavior for inactive players).
lua/wikis/commons/Widget/Squad/Player.lua New widget3 player-row renderer for squad tables (ID/opponent, loan team icon, role, dates, etc.).
lua/wikis/commons/Widget/Squad/Header.lua New widget3 header-row renderer for squad tables with column-visibility support.
lua/wikis/commons/Widget/Squad/Core/Tldb.lua Remove legacy TLDB squad widget implementation.
lua/wikis/commons/Widget/Squad/Core.lua Remove legacy core squad widget implementation.
lua/wikis/commons/Widget/Squad/Container.lua New widget3 table container (title + header + body).
lua/wikis/commons/Widget/Contexts/Squad.lua Migrate squad contexts to ComponentContext (new definitions/defaults).
lua/wikis/commons/Squad/Utils.lua Add squad wrapper helpers; adjust column-visibility logic; remove legacy default runners.
lua/wikis/commons/Squad/Row.lua Remove legacy row-builder class implementation.
lua/wikis/commons/Squad/Custom.lua Switch commons entrypoint to delegate to Squad/Controller.
lua/wikis/commons/Squad/Controller.lua New shared squad controller (args parsing, LPDB saving, context providers, rendering).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/commons/Squad/Utils.lua Outdated
Comment thread lua/wikis/commons/Squad/Controller.lua
Comment thread lua/wikis/commons/Squad/Controller.lua
Comment thread lua/wikis/commons/Squad/Controller.lua
Comment thread lua/wikis/commons/Widget/Squad/Player.lua
Comment thread lua/wikis/commons/Widget/Contexts/Squad.lua Outdated
Comment thread lua/wikis/smash/Opponent/Custom.lua
Comment thread lua/wikis/commons/Widget/Squad/Player.lua
Comment thread lua/wikis/commons/Widget/Squad/Header.lua
Comment thread lua/wikis/commons/Squad/Utils.lua
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 25 changed files in this pull request and generated 5 comments.

Comment thread lua/wikis/starcraft2/Squad/Custom.lua
Comment thread lua/wikis/commons/Squad/Utils.lua
Comment thread lua/wikis/commons/Squad/Utils.lua
Comment thread lua/wikis/smash/Opponent/Custom.lua
Comment thread lua/wikis/smash/Opponent/Custom.lua Outdated
Comment thread lua/wikis/commons/Squad/Utils.lua
@Rathoz Rathoz requested review from Eetwalt and hjpalpha May 12, 2026 10:27
@Rathoz Rathoz merged commit 8443f09 into main May 12, 2026
7 checks passed
@Rathoz Rathoz deleted the squad-refactor branch May 12, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants