refactor(squad): use widget3 and general refactor#7425
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Squad table rendering to a widget3/component-based implementation, introducing a shared Squad/Controller and new squad table components, and migrating some wiki-specific squad customizations to use the new flow.
Changes:
- Introduce
Module:Squad/Controllerand new widget3 squad components (Widget/Squad/{Container,Header,Player}) and rewire commons + some wikis to use them. - Replace the legacy squad widget/row implementation (
Widget/Squad/Core*,Squad/Row) and older context system usage inWidget/Contexts/Squad. - Remove wiki-specific squad custom modules for Overwatch and Dota 2; refactor Smash and StarCraft II custom squad modules.
Reviewed changes
Copilot reviewed 15 out of 24 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/starcraft2/Squad/Custom.lua | Switch SC2 squad rendering to Squad/Controller and add LPDB adjustment hook for grouping. |
| lua/wikis/smash/Squad/Custom.lua | Wrap squad rendering with a new GameTitle component context and delegate to Squad/Controller. |
| lua/wikis/smash/Opponent/Custom.lua | Add CustomOpponent.resolve() to sync player character mains via LPDB when syncPlayer is enabled. |
| lua/wikis/overwatch/Squad/Custom.lua | Delete Overwatch custom squad implementation (previously added “Number” column behavior). |
| lua/wikis/dota2/Squad/Custom.lua | Delete Dota 2 custom squad implementation (previously added “Active Team” behavior for inactive players). |
| lua/wikis/commons/Widget/Squad/Player.lua | New widget3 player-row renderer for squad tables (ID/opponent, loan team icon, role, dates, etc.). |
| lua/wikis/commons/Widget/Squad/Header.lua | New widget3 header-row renderer for squad tables with column-visibility support. |
| lua/wikis/commons/Widget/Squad/Core/Tldb.lua | Remove legacy TLDB squad widget implementation. |
| lua/wikis/commons/Widget/Squad/Core.lua | Remove legacy core squad widget implementation. |
| lua/wikis/commons/Widget/Squad/Container.lua | New widget3 table container (title + header + body). |
| lua/wikis/commons/Widget/Contexts/Squad.lua | Migrate squad contexts to ComponentContext (new definitions/defaults). |
| lua/wikis/commons/Squad/Utils.lua | Add squad wrapper helpers; adjust column-visibility logic; remove legacy default runners. |
| lua/wikis/commons/Squad/Row.lua | Remove legacy row-builder class implementation. |
| lua/wikis/commons/Squad/Custom.lua | Switch commons entrypoint to delegate to Squad/Controller. |
| lua/wikis/commons/Squad/Controller.lua | New shared squad controller (args parsing, LPDB saving, context providers, rendering). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eetwalt
approved these changes
May 12, 2026
hjpalpha
approved these changes
May 12, 2026
Eetwalt
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major refactor of Squads in general, to be more clean. Done as an extended part of Widget3 in reality implementation.
Moves dota2 custom field into core. Remove OW custom field as it is no longer used on that wiki. Removed some SC1 stuff, as it's been broken for a while and no1 has complained. Moved Smash display stuff to Smash Opponent Display
How did you test this change?
dev