Skip to content

Add a better ICINGA Webui output und a new argument --no-early-break to disable the early break #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheCry wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a better ICINGA Webui output und a new argument --no-early-break to disable the early break #1141

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b491a9c
Better ICINGA Webui output
TheCry May 20, 2026
53a1c09
New argument --no-early-break to disable the early break
TheCry May 20, 2026
cb77345
Merge branch 'Linuxfabrik:main' into main
TheCry May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions check-plugins/file-count/file-count
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ def parse_args():
default=False,
)

parser.add_argument(
'--no-early-break',
help='Disable early break optimization and count all matching files.',
dest='NO_EARLY_BREAK',
action='store_true',
default=False,
)

parser.add_argument(
'--password',
help='Password for SMB authentication.',
Expand Down Expand Up @@ -202,7 +210,10 @@ def main():
exceeded_threshold = False

# Determine if we can break early for performance
early_break_at = get_early_break_threshold(args.WARN, args.CRIT)
if args.NO_EARLY_BREAK:
early_break_at = None
else:
early_break_at = get_early_break_threshold(args.WARN, args.CRIT)

if args.FILENAME:
path = Path(args.FILENAME)
Expand Down Expand Up @@ -293,7 +304,8 @@ def main():
display_count = file_count - 1
msg = (
f'Found more than {display_count} matching '
f'{lib.txt.pluralize("file", display_count)} (thresholds {args.WARN}/{args.CRIT})'
f'{lib.txt.pluralize("file", display_count)} '
f'(thresholds {args.WARN}/{args.CRIT}, early-break active)'
)
else:
msg = (
Expand All @@ -309,6 +321,15 @@ def main():
_min=0,
)

state_text = {
STATE_OK: 'OK',
STATE_WARN: 'WARNING',
STATE_CRIT: 'CRITICAL',
STATE_UNKNOWN: 'UNKNOWN'
}.get(state, 'UNKNOWN')

msg = f'[{state_text}] {msg}'

# over and out
lib.base.oao(msg, state, perfdata, always_ok=args.ALWAYS_OK)

Expand Down