Skip to content

feat(librenms-alerts): add device-type "management" #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danyalberchtoldlf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(librenms-alerts): add device-type "management" #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Build, CI/CD:

Monitoring Plugins:

* librenms-alerts: add device-type 'management'
* by-ssh: add alerting on single numeric values
* by-winrm: executes commands on remote Windows hosts by WinRM, supporting JEA (including the JEA endpoint via `--winrm-configuration-name`)
* nextcloud-enterprise: provides information about an installed Nextcloud Enterprise subscription
Expand Down
2 changes: 1 addition & 1 deletion check-plugins/librenms-alerts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ usage: librenms-alerts [-h] [-V] [--always-ok] [--defaults-file DEFAULTS_FILE]
[--defaults-group DEFAULTS_GROUP]
[--device-group DEVICE_GROUP]
[--device-hostname DEVICE_HOSTNAME]
[--device-type {appliance,collaboration,environment,firewall,loadbalancer,network,power,printer,server,storage,wireless,workstation}]
[--device-type {appliance,collaboration,environment,firewall,management,loadbalancer,network,power,printer,server,storage,wireless,workstation}]
[--lengthy] [--severity {warn,crit}]
[--timeout TIMEOUT]

Expand Down
3 changes: 2 additions & 1 deletion check-plugins/librenms-alerts/librenms-alerts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,12 @@ def parse_args():
help='Filter by LibreNMS Device Type (repeating).',
dest='DEVICE_TYPE',
action='append',
choices=[ # taken from the librenms source file misc/config_definitions.json
choices=[ # taken from the librenms source file resources/definitions/config_definitions.json
'appliance',
'collaboration',
'environment',
'firewall',
'management',
'loadbalancer',
'network',
'power',
Expand Down