Repository navigation
feat(workspaces): assemble an attachment's instructions from agent, shared and harness - #1061
Merged
Merged
Conversation
LinuxDevil
added a commit
that referenced
this pull request
Nov 12, 2026
…n agent (#1061) Fail on missing main-harness prose, file-style provenance labels, and no empty Pages block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
force-pushed
the
fb-prod-assemble
branch
from
November 12, 2026 07:53
1c9dc4f to
7a46eb9
Compare
…n agent (#1061) Fail on missing main-harness prose, file-style provenance labels, and no empty Pages block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
force-pushed
the
fb-prod-assemble
branch
from
November 12, 2026 08:03
7a46eb9 to
01ef4da
Compare
LinuxDevil
marked this pull request as ready for review
November 12, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The same agent must run under different harnesses without duplicating its definition. The harness is injected per run and never written into the agent (P1.6).
Changes
src/workspaces/runtime/assemble.ts:assembleInstructions(agent,## Workspace rules,## Task environment: <page>,## Your role on this page, engine framing outside the harness hash) returning{ text, sections, harnessPart, harnessPartHash, hash, explain() };assembleMainInstructions;agentRunOptions(model, model hints, limits combined with min).lousho/workspaces;api/workspaces.api.mdupdated.Testing
npx vitest run src/workspaces/runtime/assemble.test.ts: 15 pass, including the ticket's six named tests.npx vitest run src/workspaces: all tests pass; stores/dbSource suites cannot load locally (pgand@electric-sql/pglitemissing in the shared node_modules).🤖 Generated with Claude Code