orient.comp: Add modes with preceding referencing to index signal#4249
Open
Sigma1912 wants to merge 1 commit into
Open
orient.comp: Add modes with preceding referencing to index signal#4249Sigma1912 wants to merge 1 commit into
Sigma1912 wants to merge 1 commit into
Conversation
BsAtHome
reviewed
Jul 18, 2026
Comment on lines
+72
to
+73
| static double target_angle; | ||
| static double latched_position; |
Contributor
There was a problem hiding this comment.
This is not a singleton component so these should be instance variables declared as such, next to the other instance variables. Making them static will overwrite these values when another instance runs and that is not what you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some spindle encoder setups cannot track the encoder position when using high spindle speeds and thus cannot use the current 'orient' component due to lost encoder position.
This PR expands the orient component with three additional modes that offer referencing to an index signal prior to orienting the spindle.
Current behavior is unchanged. All modes have been tested on real hardware.
Based on work by @andypugh
For more:
https://forum.linuxcnc.org/10-advanced-configuration/42792-m19-and-spindle-index-enable-issues?start=10