shellcheck: Resolve tilde expansion issue and ensure detection in CI#4243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the final shellcheck issue.
The tilde expansion issue was only detected after configure had run and the proper scripts generated. The tilde has been replaced by the
$HOMEequivalent and gets expanded at the right time.CI for shellcheck now adds a configure step so that it will expand the *.in scripts, which will subsequently be tested by shellcheck.
The shellcheck CI also removes the "continue-on-error: true" marker. It is no longer needed and CI should now fail if a script does not pass.