shellcheck: Fix remaining warnings in scripts.#4242
Merged
Conversation
grandixximo
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the last of the shellcheck warnings seen in CI. The clean source tree is does no longer contain any messages in the scripts.
However, there is one left after running configure in the expanded linuxcnc script. This is in the quoted value of the
LINUXCNC_CONFIG_PATHthat contains a path and the first entry starts with a tilde. However, quoted strings are not tilde expanded and shellcheck complains.The expansion comes from configure.ac and is probably meant to be expanded to the user running LinuxCNC. But it seems to be broken the way it is done. After searching, the LINUXCNC_CONFIG_PATH environment variable is apparently not used, anywhere. So maybe it should be removed.