Skip to content

libnml: gate CMS_DISPLAY_ASCII_UPDATER banner behind debug flag #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grandixximo wants to merge 1 commit into from
+6 −1
Closed

libnml: gate CMS_DISPLAY_ASCII_UPDATER banner behind debug flag #4074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/libnml/cms/cms_dup.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@
CMS_DISPLAY_ASCII_UPDATER::CMS_DISPLAY_ASCII_UPDATER(CMS * _cms_parent):
CMS_UPDATER(_cms_parent)
{
fprintf(stderr,
// This updater is also used transiently by NML::msg2str()/str2msg() for
// ASCII string conversion of otherwise xdr-encoded buffers (e.g. task
// command logging under EMC_DEBUG_TASK_ISSUE), so the banner fired on
// normal startup. Gate it behind the CMS-constructor debug flag instead of
// printing unconditionally to stderr.
rcs_print_debug(PRINT_CMS_CONSTRUCTORS,
"* * * * * * * * * * - - - - - WARNING - - - - - * * * * * * * * * *\n"
"* CMS_DISPLAY_ASCII_UPDATER may not function properly due *\n"
"* to range limitations of some of the update() functions. *\n"
Expand Down
Loading