sim/touchy: disable EMC_DEBUG_TASK_ISSUE logging (DEBUG=0)#4073
Open
grandixximo wants to merge 1 commit into
Open
sim/touchy: disable EMC_DEBUG_TASK_ISSUE logging (DEBUG=0)#4073grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
touchy.ini was the only sim config shipping a non-zero DEBUG (0x10 = EMC_DEBUG_TASK_ISSUE). That flag makes task log every issued NML command as an ASCII string via emcCommandBuffer->msg2str(), which lazily creates a CMS_DISPLAY_ASCII_UPDATER and prints its scary 'may not function properly due to range limitations' banner on startup. The emcCommand buffer is correctly xdr-encoded; the ASCII updater is only a temporary string-conversion helper for the debug log. Setting DEBUG=0 (matching axis and gmoccapy sims) stops the task-issue logging and the spurious banner. No functional change to touchy. Surfaced by the ui-smoke tests (LinuxCNC#4054).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
touchy.ini was the only sim config shipping a non-zero DEBUG (0x10 =
EMC_DEBUG_TASK_ISSUE). That makes task log every issued NML command as an
ASCII string via emcCommandBuffer->msg2str(), which instantiates a
CMS_DISPLAY_ASCII_UPDATER and prints its "may not function properly"
banner on startup. The emcCommand buffer is correctly xdr; the ASCII
updater is only a transient string helper for the debug log.
Set DEBUG = 0 (matching axis and gmoccapy). No functional change.
Surfaced in the ui-smoke review, PR #4054.
Test: touchy sim under xvfb, banner no longer printed, GUI starts normally.