Skip to content

[v0.2] Check the MSRV on every shipped target - #39

Merged
Lingbou merged 1 commit into
mainfrom
chore/msrv-cross-platform
Sep 30, 2026
Merged

Lingbou merged 1 commit into
mainfrom
chore/msrv-cross-platform

Conversation

@Lingbou

@Lingbou Lingbou commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Parent: #1

Closes #38

What changed

The MSRV job now installs the four shipped targets (x86_64-apple-darwin, aarch64-apple-darwin, x86_64-pc-windows-msvc, aarch64-pc-windows-msvc) alongside Rust 1.88, keeps the host check, and adds a loop that type-checks each target with --all-targets.

cargo check does not link, so an Ubuntu runner verifies every platform's code path without a macOS or Windows runner — which is exactly how the Windows and macOS work was de-risked locally.

Why it matters

rust-version = "1.88" is a statement about every artifact we publish. Until now the job only proved it for Linux, so a std API that stabilised after 1.88 on the Windows arm of the seam, the confirmation wait, or the file-identity helper would have passed CI and broken the release build.

Verification

  • Ran the exact loop locally before opening this: all four targets pass cargo +1.88.0 check --all-targets --locked — so this is coverage, not a fix.
  • actionlint clean; the new job is the CI evidence.

The 1.88 promise covers the macOS and Windows artifacts too, but the
job only type-checked the Linux host. Checking the four shipped targets
costs seconds because cargo check does not link, and it is the only
thing that would catch a newer std API on a platform-specific path.

Refs #38

Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
@Lingbou
Lingbou merged commit e16836d into main Sep 30, 2026
15 checks passed
@Lingbou
Lingbou deleted the chore/msrv-cross-platform branch September 30, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v0.2] Check the MSRV on every shipped target

1 participant