Repository navigation
[v0.2] Check the MSRV on every shipped target - #39
Merged
Merged
Conversation
The 1.88 promise covers the macOS and Windows artifacts too, but the job only type-checked the Linux host. Checking the four shipped targets costs seconds because cargo check does not link, and it is the only thing that would catch a newer std API on a platform-specific path. Refs #38 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #1
Closes #38
What changed
The MSRV job now installs the four shipped targets (
x86_64-apple-darwin,aarch64-apple-darwin,x86_64-pc-windows-msvc,aarch64-pc-windows-msvc) alongside Rust 1.88, keeps the host check, and adds a loop that type-checks each target with--all-targets.cargo checkdoes not link, so an Ubuntu runner verifies every platform's code path without a macOS or Windows runner — which is exactly how the Windows and macOS work was de-risked locally.Why it matters
rust-version = "1.88"is a statement about every artifact we publish. Until now the job only proved it for Linux, so a std API that stabilised after 1.88 on the Windows arm of the seam, the confirmation wait, or the file-identity helper would have passed CI and broken the release build.Verification
cargo +1.88.0 check --all-targets --locked— so this is coverage, not a fix.actionlintclean; the new job is the CI evidence.