Repository navigation
[v0.2] Support native Windows on x86_64 and arm64 - #37
Merged
Merged
Conversation
CI runs fmt, clippy, tests, and a release build on windows-latest and windows-11-arm, and the release pipeline publishes a per-architecture zip containing line.exe, its README, and its license. Both READMEs document the install path and the OpenSSH dependency. Refs #30 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
The name rule used the host's path separator, so Windows accepted 'prod/root' even though Windows treats '/' as a separator, and neither platform rejected Windows device names or its reserved characters. The rule is now the union of the platforms Line ships on, which is what a portable ~/.line needs. Refs #30 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
Windows cannot open a directory as a file, so the post-rename directory flush failed with access denied and every store save failed. NTFS applies the rename to its own metadata journal and the contents were flushed before the rename, so the platform seam documents that instead of pretending to sync. Refs #30 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #1
Closes #30
The platform implementation, the runtime port, and the saved-password refusal landed in #36 (closing #35). This PR finishes the ticket: real Windows runners, release artifacts, and documentation.
What changed
windowsmatrix overwindows-latest(x86_64) andwindows-11-arm(arm64) runningcargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings,cargo test --all-targets, a release build, and a--version/--listsmoke test against the builtline.exe.line-v<version>-<target>.zipcontainingline.exe,README.md, andLICENSE, uploaded to the same release as the Linux and macOS artifacts.Why the zip is built with PowerShell
packaging/make-tarball.shis bash +tar.gz. Windows needsCompress-Archive, so the packaging step is a small PowerShell script inside the workflow rather than a fourth variant of the shell script, and it mirrors the tarball layout exactly (versioned directory, binary, README, LICENSE).Verification
actionlintclean.cargo test --all-targets --locked,cargo fmt --check.cargo check/cargo clippy -D warningsfor bothx86_64-pc-windows-msvcandaarch64-pc-windows-msvc, including acargo +1.88.0run against the x86_64 target.