Skip to content

[v0.2] Support native Windows on x86_64 and arm64 - #37

Merged
Lingbou merged 3 commits into
mainfrom
feat/windows-releases
Sep 30, 2026
Merged

Lingbou merged 3 commits into
mainfrom
feat/windows-releases

Conversation

@Lingbou

@Lingbou Lingbou commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Parent: #1

Closes #30

The platform implementation, the runtime port, and the saved-password refusal landed in #36 (closing #35). This PR finishes the ticket: real Windows runners, release artifacts, and documentation.

What changed

  • CI gains a windows matrix over windows-latest (x86_64) and windows-11-arm (arm64) running cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings, cargo test --all-targets, a release build, and a --version/--list smoke test against the built line.exe.
  • Release gains a Windows matrix per architecture: build, smoke test, and package line-v<version>-<target>.zip containing line.exe, README.md, and LICENSE, uploaded to the same release as the Linux and macOS artifacts.
  • README / README_CN document the two archives, the Windows Terminal usage, the optional OpenSSH Client feature, and the fact that saved passwords are refused on Windows.
  • ADR-0001 records the Windows packaging shape: one zip per architecture, and WSL keeping the Linux artifacts.

Why the zip is built with PowerShell

packaging/make-tarball.sh is bash + tar.gz. Windows needs Compress-Archive, so the packaging step is a small PowerShell script inside the workflow rather than a fourth variant of the shell script, and it mirrors the tarball layout exactly (versioned directory, binary, README, LICENSE).

Verification

  • actionlint clean.
  • Linux suite unaffected: cargo test --all-targets --locked, cargo fmt --check.
  • Windows compile coverage was proven locally before spending runner time: cargo check/cargo clippy -D warnings for both x86_64-pc-windows-msvc and aarch64-pc-windows-msvc, including a cargo +1.88.0 run against the x86_64 target.
  • The Windows CI legs in this PR are the first real execution on Windows; they run the portable half of the suite plus the new platform tests.

CI runs fmt, clippy, tests, and a release build on windows-latest and
windows-11-arm, and the release pipeline publishes a per-architecture zip
containing line.exe, its README, and its license. Both READMEs document
the install path and the OpenSSH dependency.

Refs #30

Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
The name rule used the host's path separator, so Windows accepted
'prod/root' even though Windows treats '/' as a separator, and neither
platform rejected Windows device names or its reserved characters. The
rule is now the union of the platforms Line ships on, which is what a
portable ~/.line needs.

Refs #30

Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
Windows cannot open a directory as a file, so the post-rename directory
flush failed with access denied and every store save failed. NTFS applies
the rename to its own metadata journal and the contents were flushed
before the rename, so the platform seam documents that instead of
pretending to sync.

Refs #30

Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
@Lingbou
Lingbou merged commit 0e6924f into main Sep 30, 2026
15 checks passed
@Lingbou
Lingbou deleted the feat/windows-releases branch September 30, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v0.2] Support native Windows on x86_64 and arm64

1 participant